Skip to content

Conversation

mandreko-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/VULN-254

📔 Objective

Use the new reusable workflow file in the gh-actions repo. This allows modularity as well as easier maintenance, while reducing copied code.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

github-actions bot commented Jul 25, 2025

Logo
Checkmarx One – Scan Summary & Details396a0db7-c94a-4c01-a346-a4a04d3e872b

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@pixman20 pixman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandreko-bitwarden Is the zscaler.pem needed in this repo?

@mandreko-bitwarden
Copy link
Contributor Author

@mandreko-bitwarden Is the zscaler.pem needed in this repo?

No, that was a mistake. Thanks for catching it. This should be ready again.

Copy link

@mandreko-bitwarden mandreko-bitwarden merged commit e36eb03 into main Aug 13, 2025
6 checks passed
@mandreko-bitwarden mandreko-bitwarden deleted the reusable-scan branch August 13, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants